On Mon, Dec 14, 2020 at 6:44 PM David Ahern <dsahern@xxxxxxxxx> wrote: > > On 12/14/20 6:53 PM, Alexander Duyck wrote: > >> example subfunction usage sequence: > >> ----------------------------------- > >> Change device to switchdev mode: > >> $ devlink dev eswitch set pci/0000:06:00.0 mode switchdev > >> > >> Add a devlink port of subfunction flaovur: > >> $ devlink port add pci/0000:06:00.0 flavour pcisf pfnum 0 sfnum 88 > > > > Typo in your description. Also I don't know if you want to stick with > > "flavour" or just shorten it to the U.S. spelling which is "flavor". > > The term exists in devlink today (since 2018). When support was added to > iproute2 I decided there was no reason to require the US spelling over > the British spelling, so I accepted the patch. Okay. The only reason why I noticed is because "flaovur" is definitely a wrong spelling. If it is already in the interface then no need to change it.