On 2020/12/11 8:16, Jason Gunthorpe wrote: > On Thu, Dec 10, 2020 at 09:54:28PM +0800, Weihang Li wrote: >> There are miscellaneous updates for hns driver: >> * #1 fixes a potential length issue when copying udata. >> * #2 fixes the unreasonable judgment when using HEM of SRQ and SCCC. >> * #3 fixes wrong value of Traffic Class. >> * #4 and #5 fix issues about Service Level. >> * #6 ~ #11 are cleanups, including removing dead code, fixing coding style >> issues and so on. > > Doesn't compile: > > In file included from drivers/infiniband/hw/hns/hns_roce_hw_v1.c:40: > drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function ‘set_eq_cons_index_v1’: > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3606:42: error: ‘struct hns_roce_eq’ has no member named ‘db_reg’ > 3606 | (req_not << eq->log_entries), eq->db_reg); > | ^~ > drivers/infiniband/hw/hns/hns_roce_common.h:39:49: note: in definition of macro ‘roce_raw_write’ > 39 | __raw_writel((__force u32)cpu_to_le32(value), (addr)) > | ^~~~ > > Jason > Sorry for that, will fix it later. Weihang