On Fri, Dec 04, 2020 at 12:20:37AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > A number of ethernet drivers require crc32 functionality to be > avaialable in the kernel, causing a link error otherwise: > > arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast': > et131x.c:(.text+0x5918): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/cadence/macb_main.o: in function `macb_start_xmit': > macb_main.c:(.text+0x4b88): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/faraday/ftgmac100.o: in function `ftgmac100_set_rx_mode': > ftgmac100.c:(.text+0x2b38): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fec_main.o: in function `set_multicast_list': > fec_main.c:(.text+0x6120): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o: in function `dtsec_add_hash_mac_address': > fman_dtsec.c:(.text+0x830): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o:fman_dtsec.c:(.text+0xb68): more undefined references to `crc32_le' follow > arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_hwinfo.o: in function `nfp_hwinfo_read': > nfp_hwinfo.c:(.text+0x250): undefined reference to `crc32_be' > arm-linux-gnueabi-ld: nfp_hwinfo.c:(.text+0x288): undefined reference to `crc32_be' > arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.o: in function `nfp_resource_acquire': > nfp_resource.c:(.text+0x144): undefined reference to `crc32_be' > arm-linux-gnueabi-ld: nfp_resource.c:(.text+0x158): undefined reference to `crc32_be' > arm-linux-gnueabi-ld: drivers/net/ethernet/nxp/lpc_eth.o: in function `lpc_eth_set_multicast_list': > lpc_eth.c:(.text+0x1934): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_do': > rocker_ofdpa.c:(.text+0x2e08): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_del': > rocker_ofdpa.c:(.text+0x3074): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_port_fdb': > arm-linux-gnueabi-ld: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.o: in function `mlx5dr_ste_calc_hash_index': > dr_ste.c:(.text+0x354): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_netdev_set_multicast': > lan743x_main.c:(.text+0x5dc4): undefined reference to `crc32_le' > > Add the missing 'select CRC32' entries in Kconfig for each of them. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > drivers/net/ethernet/agere/Kconfig | 1 + > drivers/net/ethernet/cadence/Kconfig | 1 + > drivers/net/ethernet/faraday/Kconfig | 1 + > drivers/net/ethernet/freescale/Kconfig | 1 + > drivers/net/ethernet/freescale/fman/Kconfig | 1 + > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + > drivers/net/ethernet/microchip/Kconfig | 1 + > drivers/net/ethernet/netronome/Kconfig | 1 + > drivers/net/ethernet/nxp/Kconfig | 1 + > drivers/net/ethernet/rocker/Kconfig | 1 + > 10 files changed, 10 insertions(+) Hi Arnd, I'm slightly curious to know how you configured the kernel to build the Netronome NFP driver but not CRC32 but nonetheless I have no objection to this change. For the Netronome portion: Acked-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>
