On 2020/12/1 21:44, Jason Gunthorpe wrote: > On Tue, Dec 01, 2020 at 09:23:44PM +0800, Weihang Li wrote: >> diff --git a/include/uapi/rdma/hns-abi.h b/include/uapi/rdma/hns-abi.h >> index 9ec85f7..2dd5fa07 100644 >> +++ b/include/uapi/rdma/hns-abi.h >> @@ -43,6 +43,10 @@ struct hns_roce_ib_create_cq { >> __u32 reserved; >> }; >> >> +enum hns_roce_cq_cap_flags { >> + HNS_ROCE_CQ_FLAG_RECORD_DB = BIT(0), >> +}; >> + >> struct hns_roce_ib_create_cq_resp { >> __aligned_u64 cqn; /* Only 32 bits used, 64 for compat */ >> __aligned_u64 cap_flags; >> @@ -69,6 +73,12 @@ struct hns_roce_ib_create_qp { >> __aligned_u64 sdb_addr; >> }; >> >> +enum hns_roce_qp_cap_flags { >> + HNS_ROCE_QP_CAP_RQ_RECORD_DB = BIT(0), >> + HNS_ROCE_QP_CAP_SQ_RECORD_DB = BIT(1), >> + HNS_ROCE_QP_CAP_OWNER_DB = BIT(2), >> +}; > > Don't use BIT in uapi headers > > Jason > I see, thank you. Weihang