On Wed, Nov 18, 2020 at 02:46:05PM +0200, Gal Pressman wrote: > On 16/11/2020 22:23, Jason Gunthorpe wrote: > > Remove the old query_device support code, it is now replaced by > > ibv_cmd_query_device_any() > > > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > > Shouldn't the legacy fallback in ibv_query_device_ex() be removed as well? I thought about it, and yes we could convert that into a real function call and remove all the junk But if we do that it causes a symbol ver dependencies and if we are going that far then we should really just do all of the verbs_get_ctx_op() inlines and be done with that mess entirely. This would mean anything linked with a new rdma-core would not be able to load on any of the older ones.. I've been saving that gem for some future adventure since it seems to cause some general pain. It would be good to couple it with some other verbs.h clean up as well Jason
