On Mon, 2020-11-16 at 14:52 -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 21:24:10 +0200 Parav Pandit wrote: > > This series introduces support for mlx5 subfunction (SF). > > A subfunction is a portion of a PCI device that supports multiple > > classes of devices such as netdev, RDMA and more. > > > > This patchset is based on Leon's series [3]. > > It is a third user of proposed auxiliary bus [4]. > > > > Subfunction support is discussed in detail in RFC [1] and [2]. > > RFC [1] and extension [2] describes requirements, design, and > > proposed > > plumbing using devlink, auxiliary bus and sysfs for systemd/udev > > support. > > So we're going to have two ways of adding subdevs? Via devlink and > via > the new vdpa netlink thing? > Via devlink you add the Sub-function bus device - think of it as spawning a new VF - but has no actual characteristics (netdev/vpda/rdma) "yet" until user admin decides to load an interface on it via aux sysfs. Basically devlink adds a new eswitch port (the SF port) and loading the drivers and the interfaces is done via the auxbus subsystem only after the SF is spawned by FW. > Question number two - is this supposed to be ready to be applied to > net-next? It seems there is a conflict. > This series requires other mlx5 and auxbus infrastructure dependencies that was already submitted by leon 2-3 weeks ago and pending Greg's review, once finalized it will be merged into mlx5-next, then I will ask you to pull mlx5-next and only after, you can apply this series cleanly to net-next, sorry for the mess but we had to move forward and show how auxdev subsystem is being actually used. Leon's series: https://patchwork.ozlabs.org/project/netdev/cover/20201101201542.2027568-1-leon@xxxxxxxxxx/ > Also could you please wrap your code at 80 chars? > I prefer no to do this in mlx5, in mlx5 we follow a 95 chars rule. But if you insist :) .. Thanks, Saeed.
