On Sun, Nov 15, 2020 at 12:34:02PM +0200, Gal Pressman wrote: > Drivers now expose two callbacks for address handle creation, one for > uverbs and one for kverbs. The function pointer NULL check in > _rdma_create_ah() should only happen if !udata. > > A NULL check for .create_user_ah is not needed as it is validated by the > uverbs uapi definitions. > > Fixes: 676a80adba01 ("RDMA: Remove AH from uverbs_cmd_mask") Why is this a fixes? It makes sense in the context of the next patch, but it doesn't look like any driver sets ops.create_ah == NULL ? Jason