> -----Original Message----- > From: Leon Romanovsky <leonro@xxxxxxxxxx> > Sent: Thursday, November 5, 2020 11:35 AM > To: Ertman, David M <david.m.ertman@xxxxxxxxx> > Cc: Williams, Dan J <dan.j.williams@xxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; > Takashi Iwai <tiwai@xxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; linux- > rdma <linux-rdma@xxxxxxxxxxxxxxx>; Jason Gunthorpe <jgg@xxxxxxxxxx>; > Doug Ledford <dledford@xxxxxxxxxx>; Netdev <netdev@xxxxxxxxxxxxxxx>; > David Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>; Ranjani Sridharan > <ranjani.sridharan@xxxxxxxxxxxxxxx>; Pierre-Louis Bossart <pierre- > louis.bossart@xxxxxxxxxxxxxxx>; Fred Oh <fred.oh@xxxxxxxxxxxxxxx>; Parav > Pandit <parav@xxxxxxxxxxxx>; Saleem, Shiraz <shiraz.saleem@xxxxxxxxx>; > Patil, Kiran <kiran.patil@xxxxxxxxx>; Linux Kernel Mailing List <linux- > kernel@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH v3 01/10] Add auxiliary bus support > > On Thu, Nov 05, 2020 at 07:27:56PM +0000, Ertman, David M wrote: > > > -----Original Message----- > > > From: Dan Williams <dan.j.williams@xxxxxxxxx> > > > Sent: Thursday, November 5, 2020 1:19 AM > > > To: Ertman, David M <david.m.ertman@xxxxxxxxx> > > > Cc: alsa-devel@xxxxxxxxxxxxxxxx; Takashi Iwai <tiwai@xxxxxxx>; Mark > Brown > > > <broonie@xxxxxxxxxx>; linux-rdma <linux-rdma@xxxxxxxxxxxxxxx>; Jason > > > Gunthorpe <jgg@xxxxxxxxxx>; Doug Ledford <dledford@xxxxxxxxxx>; > > > Netdev <netdev@xxxxxxxxxxxxxxx>; David Miller > <davem@xxxxxxxxxxxxx>; > > > Jakub Kicinski <kuba@xxxxxxxxxx>; Greg KH > <gregkh@xxxxxxxxxxxxxxxxxxx>; > > > Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>; Pierre-Louis > Bossart > > > <pierre-louis.bossart@xxxxxxxxxxxxxxx>; Fred Oh > <fred.oh@xxxxxxxxxxxxxxx>; > > > Parav Pandit <parav@xxxxxxxxxxxx>; Saleem, Shiraz > > > <shiraz.saleem@xxxxxxxxx>; Patil, Kiran <kiran.patil@xxxxxxxxx>; Linux > > > Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Leon Romanovsky > > > <leonro@xxxxxxxxxx> > > > Subject: Re: [PATCH v3 01/10] Add auxiliary bus support > > > > > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman > <david.m.ertman@xxxxxxxxx> > > > wrote: > > <...> > > > > > Again, thanks for the review Dan. Changes will be in next release (v4) once > I give > > stake-holders a little time to respond. > > Everything here can go as a Fixes, the review comments are valuable and > need > to be fixed, but they don't change anything dramatically that prevent from > merging v3. > This works for me - I have the changes saved into an add-on patch that I haven't squashed into the main patch yet. > Thanks > > > > > -DaveE