Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Fix the active_speed and phys_state value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 02, 2020 at 10:54:37PM +0000, Adit Ranadive wrote:
> The PVRDMA device still reports the active_speed in u8.
> The pvrdma_port_attr structure is used by the device to report the
> port attributes in the device API query port response structure -
> pvrdma_cmd_query_port_resp - and shouldn't be changed.
> 
> Fixes: 376ceb31ff87 ("RDMA: Fix link active_speed size")
> Reviewed-by: Vishnu Dasa <vdasa@xxxxxxxxxx>
> Signed-off-by: Adit Ranadive <aditr@xxxxxxxxxx>
> ---
> 
> Changelog:
>  - v0->v1: Reverted the structure layout only as per Jason. Updated description.
> ---
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc

If you think it is better you can send another patch to use the
ib_get_eth_speed() function

Also please send a patch to move all of these ABI structs into the
pvrdma_dev_api.h - ABI structures should not be strewn randomly over
header files, it leads to mistakes like this.

Thanks,
Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux