-----"Zhang Qilong" <zhangqilong3@xxxxxxxxxx> wrote: ----- >To: <bmt@xxxxxxxxxxxxxx>, <dledford@xxxxxxxxxx>, <jgg@xxxxxxxx> >From: "Zhang Qilong" <zhangqilong3@xxxxxxxxxx> >Date: 10/28/2020 10:44PM >Cc: <linux-rdma@xxxxxxxxxxxxxxx> >Subject: [EXTERNAL] [PATCH] RDMA/siw: fix wrong judgment in >siw_cm_work_handler > >The rv cannot be 'EAGAIN' in the previous path, we >should use '-EAGAIN' to check it. For example: > >Call trace: >->siw_cm_work_handler > ->siw_proc_mpareq > ->siw_recv_mpa_rr > >Signed-off-by: Zhang Qilong <zhangqilong3@xxxxxxxxxx> >--- > drivers/infiniband/sw/siw/siw_cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/infiniband/sw/siw/siw_cm.c >b/drivers/infiniband/sw/siw/siw_cm.c >index 66764f7ef072..1f9e15b71504 100644 >--- a/drivers/infiniband/sw/siw/siw_cm.c >+++ b/drivers/infiniband/sw/siw/siw_cm.c >@@ -1047,7 +1047,7 @@ static void siw_cm_work_handler(struct >work_struct *w) > cep->state); > } > } >- if (rv && rv != EAGAIN) >+ if (rv && rv != -EAGAIN) > release_cep = 1; > break; > >-- >2.17.1 > > Thanks Zhang, good catch! Reviewed-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
