On 10/26/20 10:59 PM, Leon Romanovsky wrote: > +/** > + * srpt_unregister_mad_agent - unregister MAD callback functions > + * @sdev: SRPT HCA pointer. > + * > + * Note: It is safe to call this function more than once for the same device. > + */ > +static void srpt_unregister_mad_agent(struct srpt_device *sdev) > +{ > + __srpt_unregister_mad_agent(sdev, sdev->device->phys_port_cnt); > +} As far as I can see with this patch applied srpt_unregister_mad_agent() has no callers. So please add an argument to srpt_unregister_mad_agent() instead of introducing __srpt_unregister_mad_agent(). Thanks, Bart.