On Fri, Oct 16, 2020 at 03:20:50PM -0500, Bob Pearson wrote: > Jason, > > Your recent commit: > > commit e0d696d201dd5d31813787d9b61a42fc459eee89 > Author: Jason Gunthorpe <jgg@xxxxxxxx> > Date: Thu Oct 15 20:42:18 2020 -0300 > > RDMA/rxe: Move the definitions for rxe_av.network_type to uAPI > > has some problems and so far I am having trouble making it work sensibly. > > What you have done is to make the network_type field in rxe_av be private, > (i.e. RXE_NETWORK_TYPE_XXX instead of RDMA_NETWORK_XXX). You then defined these > private enums in rdma_uverbs_rxe.h. The problem is that there are more than one > source of AVs those: Bah, I missed rxe_av_fill_ip_info(), still it should just transcode for now. > There was also a confusion between V6 and V4. I will submit a small patch that > fixes that and makes the enums the same again which is more efficient than transocding > them. Bah again. People need to check the stuff I write at 9pm :P Jason
