On 10/15/20 6:47 PM, Jason Gunthorpe wrote: > On Thu, Oct 15, 2020 at 03:17:51PM -0500, Bob Pearson wrote: >> Update enum rdma_network_type copy to match kernel version. >> Without this change provider/rxe will send incorrect >> network types to the kernel in send WQEs. >> >> This fix keeps rxe functional but should be replaced by a better >> implementation. >> >> Signed-off-by: Bob Pearson <rpearson@xxxxxxx> >> --- >> providers/rxe/rxe.h | 1 + >> 1 file changed, 1 insertion(+) > > Well, we can't just break user space so the kernel has to change in > some way to accommodate this. > > Obviously rxe should not have uAPI stuff that is not in > include/uapi/rdma, so lets just fix that directly. > > Please confirm I did this right. The PR for this merge window must be > sent Friday. That works too. I am figuring out how to convert ah_handle to ib_ah in rdma_rxe. I think I've mostly got it. uobj_get_obj_read(type, id, attr) is close to what I need. The problem is that all the code in this area assumes it is getting called in a user verb API call so there is an attr to pass around. What we need is an API like rdma_get_obj(ucontext, type, id) since we need a way to get to the user api data structures. Better would be a pointer from qp to ucontext or ufile that would be set for user QPs. If we did this rxe just use handles from the core instead of creating its own databases of objects. Your patch will get us going for now. The above is a longer project that won't fit in your short term schedule. Bob
