On Fri, Oct 09, 2020 at 10:10:06PM +0530, Potnuri Bharat Teja wrote: > On Monday, October 10/05/20, 2020 at 21:47:26 +0530, Jason Gunthorpe wrote: > > On Mon, Oct 05, 2020 at 08:56:52AM +0300, Leon Romanovsky wrote: > > > > > > - mhp->rhp = rhp; > > > > - mhp->attr.pdid = php->pdid; > > > > - mhp->attr.type = FW_RI_STAG_MW; > > > > > > 75% of "enum fw_ri_stag_type" can be removed too. > > > > I think that is the code-gen'd HW API for this driver, I don't mind > > leaving it. It seems the HW supports MW, just nobody plumbed it > > through to rdma-core > > > Hi Jason, > Agreed its dead code as is but Chelsio HW suports MW and we are yet to decide on > requirements, we may probably add userspace support for MW in future. You can't add userspace support without modifying the kernel since the ucmd_mask was never, set. So when/if you get everything working send a kernel series bringing these functions back. Jason
