On 10/13/20 8:08 AM, Pierre-Louis Bossart wrote: > >>>>>> +config SND_SOC_SOF_CLIENT >>>>>> + tristate >>>>>> + select ANCILLARY_BUS >>>>>> + help >>>>>> + This option is not user-selectable but automagically handled by >>>>>> + 'select' statements at a higher level >>>>>> + >>>>>> +config SND_SOC_SOF_CLIENT_SUPPORT >>>>>> + bool "SOF enable clients" >>>>> >>>>> Tell users what "SOF" means. >>>> >>>> This option can only be reached if the user already selected the topic-level option. From there on the SOF acronym is used. Is this not enough? >>> >>> Yes, that's enough. I didn't see it. Sorry about that. >> >> Huh. I still don't see that Kconfig option. >> Which patch is it in? >> >> I only saw patches 1,2,3 on LKML. > > The Sound Open Firmware (SOF) driver is upstream since 2019, see https://elixir.bootlin.com/linux/latest/source/sound/soc/sof/Kconfig > > What was shared in these patches is just an evolution to make the driver more modular to handle of 'subfunctions' with the auxiliary bus. > > we'd love to hear your feedback if you think the help text can be improved. Thanks! > OK, I looked at the SOF Kconfig files. They are mostly OK except for missing '.' at the end of lots of sentences and a few other typos. Do you want patches? -- ~Randy