Thanks David for your feedback.
I will submit v3 of this patch removing the warning.
-Manjunath
On 10/3/2020 5:26 PM, David Miller wrote:
From: Manjunath Patil <manjunath.b.patil@xxxxxxxxxx>
Date: Fri, 2 Oct 2020 13:05:45 -0700
RDS/IB tries to refill the recv buffer in softirq context using
GFP_NOWAIT flag. However alloc failure is handled by queueing a work to
refill the recv buffer with GFP_KERNEL flag. This means failure to
allocate with GFP_NOWAIT isn't fatal. Do not print the PAF warnings if
softirq context fails to refill the recv buffer, instead print rate
limited warnings.
Signed-off-by: Manjunath Patil <manjunath.b.patil@xxxxxxxxxx>
Reviewed-by: Aruna Ramakrishna <aruna.ramakrishna@xxxxxxxxxx>
Honestly I don't think the subsystem should print any warning at all.
Either it's a softirq failure, and that's ok because you will push
the allocation to GFP_KERNEL via a work job. Or it's a GFP_KERNEL
failure in non-softirq context and the kernel will print a warning
and a stack backtrace from the memory allocator.
Therefore, please remove all of the warnings in the rds code.
Thanks.
