On Sun, Oct 04, 2020 at 04:29:48PM +0300, Kamal Heib wrote: > To avoid inconsistent user experience for PKey interfaces that are > created via netlink VS PKey interfaces that are created via sysfs and > parent interfaces, make sure to set the rtnl_link_ops for all ipoib > network devices (PKeys and parent interfaces), so the ipoib attributes > will be reported/modified via iproute2 for all ipoib interfaces > regardless of how they are created. > > Also, after setting the rtnl_link_ops for the parent interface, implement > the dellink() callback to block users from trying to remove it. > > Fixes: 9baa0b036410 ("IB/ipoib: Add rtnl_link_ops support") This fixes line should be Fixes: 862096a8bbf8 ("IB/ipoib: Add more rtnl_link_ops callbacks") Since there is no bug here until fill_info was added > Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx> > --- > v3: Move the setting of rtnl_link_ops to ipoib_vlan_add() and update > the commit message. > v2: Update commit message. > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 ++ > drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 11 +++++++++++ > drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 2 ++ > 3 files changed, 15 insertions(+) Applied to for-next, thanks Jason