On Tue, Sep 29, 2020 at 09:04:38AM +0300, Kamal Heib wrote: > On Mon, Sep 28, 2020 at 07:36:02PM -0300, Jason Gunthorpe wrote: > > On Mon, Sep 28, 2020 at 11:26:31PM +0300, Kamal Heib wrote: > > > Before this patch, the rtnl_link_ops are set only for ipoib network > > > devices that are created via the rtnl_link_ops->newlink() callback, this > > > patch fixes that by setting the rtnl_link_ops for all ipoib network > > > devices. Also, implement the dellink() callback to block users from > > > trying to remove the base ipoib network device while allowing it only > > > for child interfaces. > > > > Why? > > > > This is needed to avoid the inconsistent user experience for PKeys that > is created via netlink VS PKeys that is created via sysfs and the based > ipoib interface, as you can see below the ipoib attributes are reported > only for PKeys that is created via netlink in the 'ip -d link show' > output: Summarize this in the commit message please Jason
