On Mon, Sep 28, 2020 at 12:27:56PM +0000, liweihang wrote: > On 2020/9/28 19:55, Jason Gunthorpe wrote: > > On Sun, Sep 27, 2020 at 05:52:21PM +0800, Weihang Li wrote: > >> From: Lang Cheng <chenglang@xxxxxxxxxx> > >> > >> Some code was removed but the variables were still there, and some > >> parameters have been changed to be queried from firmware. So the > >> definitions of them are no longer needed. > >> > >> Signed-off-by: Lang Cheng <chenglang@xxxxxxxxxx> > >> Signed-off-by: Weihang Li <liweihang@xxxxxxxxxx> > >> drivers/infiniband/hw/hns/hns_roce_device.h | 8 -------- > >> drivers/infiniband/hw/hns/hns_roce_qp.c | 2 -- > >> 2 files changed, 10 deletions(-) > > > > Should have a fixes for the patch that removed the code > > > > Jason > > > > Hi Jason, > > Thanks for the comment. But I'm confused about when we should add > fixes tag. > > For example, The only purpose of this patch is to remove redundant > macro definitions, the macros to be removed belong to 4 different > former patches, so we have to add 4 lines of fixes. It seems difficult > to merge this one back to previous versions of kernel. You can just list all four patches Jason
