On 2020/9/25 3:00, Jason Gunthorpe wrote: > On Sat, Sep 19, 2020 at 06:03:15PM +0800, Weihang Li wrote: >> According to the IB specifications, the verbs should return an immediate >> error when the users set an unsupported opcode. Furthermore, refactor codes >> about opcode in process of post_send to make the difference between opcodes >> clearer. >> >> Signed-off-by: Weihang Li <liweihang@xxxxxxxxxx> >> --- >> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 133 +++++++++++++++++------------ >> 1 file changed, 78 insertions(+), 55 deletions(-) > > This gives compile warnings: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function ‘set_ud_wqe’: > drivers/infiniband/hw/hns/hns_roce_hw_v2.c:330:20: warning: unused variable ‘ibdev’ [-Wunused-variable] > 330 | struct ib_device *ibdev = &hr_dev->ib_dev; > | ^~~~~ > drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function ‘set_rc_wqe’: > drivers/infiniband/hw/hns/hns_roce_hw_v2.c:468:20: warning: unused variable ‘ibdev’ [-Wunused-variable] > 468 | struct ib_device *ibdev = &to_hr_dev(qp->ibqp.device)->ib_dev; > | ^~~~~ > > I deleted the unused variables > > Jason > I forgot to remove them when I replace the prints with WARN_ON(), thank you :) Weihang
