On Tue, Sep 22, 2020 at 08:24:52AM +0200, Christoph Hellwig wrote: > On Mon, Sep 21, 2020 at 12:18:13PM +0300, Leon Romanovsky wrote: > > On Mon, Sep 21, 2020 at 09:57:25AM +0200, Christoph Hellwig wrote: > > > I'm still not really sold on the explosion of specific sgl APIs, so > > > I ended up implementing my original suggestion to reuse > > > __sg_alloc_table_from_pages and just pass two additional parameters. > > > I also ended up moving the memset out of __sg_alloc_table into its > > > two callers, and I think the result looks much better, what do you > > > think? > > > > I think that the API call is really hard to grasp now with too many > > arguments. Fun part will start when someone will decide to use this API > > without some (expected for now) parameters. > > It has the same number of parameters as before, we just switch three > more callers to the tons of arguments function instead of keeping the > old one with two less arguments around. No problem, we tested it overnight and I'll send v3 today. Thanks
