Re: [PATCH rdma-next v1 1/4] IB/core: Improve ODP to use hmm_range_fault()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/21/2020 5:23 PM, Jason Gunthorpe wrote:
On Thu, Sep 17, 2020 at 02:21:49PM +0300, Leon Romanovsky wrote:

-out:
-	put_page(page);
-	return ret;
+	*dma_addr &= ODP_DMA_ADDR_MASK;
I thought we agreed to get rid of this because it must be zero?

Jason

At the end we agreed to not rely on as potentially dma_addr may be zero, the access flags are used  to mark an entry as valid in this case (see also ib_umem_odp_unmap_dma_pages).

Yishai





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux