On Fri, Sep 18, 2020 at 11:46:13AM +0300, Leon Romanovsky wrote: > On Thu, Sep 17, 2020 at 07:10:34PM +0300, Leon Romanovsky wrote: > > On Thu, Sep 17, 2020 at 12:08:13PM -0300, Jason Gunthorpe wrote: > > > On Mon, Sep 14, 2020 at 02:18:57PM +0300, Leon Romanovsky wrote: > > > > From: Leon Romanovsky <leonro@xxxxxxxxxx> > > > > > > > > Special QPs created by mlx4 have same QP port borrowed from > > > > the context, while they are expected to have different ones. > > > > > > > > Fix it by using HW physical port instead. > > > > > > > > It fixes the following error during driver init: > > > > [ 12.074150] mlx4_core 0000:05:00.0: mlx4_ib: initializing demux service for 128 qp1 clients > > > > [ 12.084036] <mlx4_ib> create_pv_sqp: Couldn't create special QP (-16) > > > > [ 12.085123] <mlx4_ib> create_pv_resources: Couldn't create QP1 (-16) > > > > [ 12.088300] mlx4_en: Mellanox ConnectX HCA Ethernet driver v4.0-0 > > > > > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> > > > > --- > > > > Changelog: > > > > v3: mlx4 devices create 2 special QPs in SRIOV mode, separate them by > > > > port number and special bit. The mlx4 is limited to two ports and not > > > > going to be extended, and the port_num is not forwarded to FW too, so > > > > it is safe. > > > > v2: https://lore.kernel.org/linux-rdma/20200907122156.478360-4-leon@xxxxxxxxxx/#r > > > > --- > > > > drivers/infiniband/hw/mlx4/mad.c | 9 +++++---- > > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > I didn't understand why this was in the restrack series, and the > > > commit doesn't say when the error can be hit > > > > restrack changes revealed it when I added these special QPs to the DB. > > It is not fix in traditional sense, so no Fixes line. > > Anyway, please wait with this patch, it makes troubles in some mlx4 > SRIOV tests. The end result that this patch is going to be replaced by this fixup to "RDMA/core: Allow drivers to disable restrack DB" patch. diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c index 7f0290112db7..e306d2aab510 100644 --- a/drivers/infiniband/hw/mlx4/qp.c +++ b/drivers/infiniband/hw/mlx4/qp.c @@ -1562,6 +1562,11 @@ static int _mlx4_ib_create_qp(struct ib_pd *pd, struct mlx4_ib_qp *qp, if (err) return err; + if (init_attr->create_flags & + (MLX4_IB_SRIOV_SQP | MLX4_IB_SRIOV_TUNNEL_QP)) + /* Internal QP created with ib_create_qp */ + rdma_restrack_no_track(&qp->ibqp.res); + qp->port = init_attr->port_num; qp->ibqp.qp_num = init_attr->qp_type == IB_QPT_SMI ? 0 : init_attr->create_flags & MLX4_IB_QP_CREATE_ROCE_V2_GSI ? sqpn : 1; > > Thanks > > > > > Thanks > > > > > > > > No fixes line? > > > > > > Jason
