On 2020-08-19 07:17, Sergey Gorenko wrote:
> There is no need to create a world-writable lock file.
> It's enough to have an RW permission for the file owner only.
>
> Signed-off-by: Sergey Gorenko <sergeygo@xxxxxxxxxx>
> Reviewed-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
> ---
> srp_daemon/srp_daemon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
> index f14d9f56c9f2..fcf94537cebb 100644
> --- a/srp_daemon/srp_daemon.c
> +++ b/srp_daemon/srp_daemon.c
> @@ -142,7 +142,6 @@ static int check_process_uniqueness(struct config_t *conf)
> return -1;
> }
>
> - fchmod(fd, S_IRUSR|S_IRGRP|S_IROTH|S_IWUSR|S_IWGRP|S_IWOTH);
> if (0 != lockf(fd, F_TLOCK, 0)) {
> pr_err("failed to lock %s (errno: %d). possibly another "
> "srp_daemon is locking it\n", path, errno);
I think the fchmod() call was introduced by commit ee138ce1e40d ("Cause
srp_daemon launch to fail if another srp_daemon is already working on the
same HCA port."). Has it been verified that with this change applied that
mechanism still works?
Anyway, please add a reference to that commit in the patch description.
Thanks,
Bart.
