On Thu, Sep 10, 2020 at 05:22:03PM +0300, Leon Romanovsky wrote:
> From: Avihai Horon <avihaih@xxxxxxxxxx>
>
> Introduce rdma_query_gid_table which enables querying all the GID tables
> of a given device and copying the attributes of all valid GID entries to
> a provided buffer.
>
> This API provides a faster way to query a GID table using single call and
> will be used in libibverbs to improve current approach that requires
> multiple calls to open, close and read multiple sysfs files for a single
> GID table entry.
>
> Signed-off-by: Avihai Horon <avihaih@xxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> drivers/infiniband/core/cache.c | 93 +++++++++++++++++++++++++
> include/rdma/ib_cache.h | 5 ++
> include/uapi/rdma/ib_user_ioctl_verbs.h | 8 +++
> 3 files changed, 106 insertions(+)
>
> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
> index cf49ac0b0aa6..175e229eccd3 100644
> +++ b/drivers/infiniband/core/cache.c
> @@ -1247,6 +1247,99 @@ rdma_get_gid_attr(struct ib_device *device, u8 port_num, int index)
> }
> EXPORT_SYMBOL(rdma_get_gid_attr);
>
> +/**
> + * rdma_get_ndev_ifindex - Reads ndev ifindex of the given gid attr.
> + * @gid_attr: Pointer to the GID attribute.
> + * @ndev_ifindex: Pointer through which the ndev ifindex is returned.
> + *
> + * Returns 0 on success or appropriate error code. The netdevice must be in UP
> + * state.
> + */
> +int rdma_get_ndev_ifindex(const struct ib_gid_attr *gid_attr, u32 *ndev_ifindex)
> +{
> + struct net_device *ndev;
> + int ret = 0;
> +
> + if (rdma_protocol_ib(gid_attr->device, gid_attr->port_num)) {
> + *ndev_ifindex = 0;
> + return 0;
> + }
> +
> + rcu_read_lock();
> + ndev = rcu_dereference(gid_attr->ndev);
> + if (!ndev || (READ_ONCE(ndev->flags) & IFF_UP) == 0) {
> + ret = -ENODEV;
> + goto out;
> + }
None of this is necessary to read the ifindex, especially since the
read_lock is being held.
> +/**
> + * rdma_query_gid_table - Reads GID table entries of all the ports of a device up to max_entries.
> + * @device: The device to query.
> + * @entries: Entries where GID entries are returned.
> + * @max_entries: Maximum number of entries that can be returned.
> + * Entries array must be allocated to hold max_entries number of entries.
> + * @num_entries: Updated to the number of entries that were successfully read.
> + *
> + * Returns 0 on success or appropriate error code.
> + */
> +int rdma_query_gid_table(struct ib_device *device,
> + struct ib_uverbs_gid_entry *entries,
> + size_t max_entries, size_t *num_entries)
return ssize_t instead of the output pointer
> +{
> + const struct ib_gid_attr *gid_attr;
> + struct ib_gid_table *table;
> + unsigned int port_num;
> + unsigned long flags;
> + int ret;
> + int i;
i is unsigned
Jason
