On Wed, Sep 09, 2020 at 11:18:49AM +0300, Gal Pressman wrote: > On 08/09/2020 16:48, Jason Gunthorpe wrote: > > On Mon, Sep 07, 2020 at 03:19:54PM +0300, Gal Pressman wrote: > >> On 05/09/2020 1:41, Jason Gunthorpe wrote: > >>> If ib_umem_find_best_pgsz() returns > PAGE_SIZE then the equation here is > >>> not correct. 'start' should be 'virt'. Change it to use the core code for > >>> page_num and the canonical calculation of page_shift. > >> > >> Should I submit a fix for stable changing start to virt? > > > > I suspect EFA users never use ibv_reg_mr_iova() so won't have an > > actual bug? > > That's still a driver bug though, regardless of the userspace so I'd rather fix it. > Should I submit a patch to for-rc? It would conflict with the for-next one. If you care enough then propose the parts of this series for backporting to stable once they are merged to Linus's tree Jason
