On Fri, Sep 04, 2020 at 07:00:38PM +0530, Md Haris Iqbal wrote:
> The device .release function was not being set during the device
> initialization. This was leading to the below warning, in error cases when
> put_srv was called before device_add was called.
>
> Warning:
>
> Device '(null)' does not have a release() function, it is broken and must
> be fixed. See Documentation/kobject.txt.
>
> So, set the device .release function during device initialization in the
> __alloc_srv() function.
>
> Fixes: baa5b28b7a474 ("RDMA/rtrs-srv: Replace device_register with..")
Please don't truncate Fixes line, many of us rely on full line for automation.
Thanks
> Signed-off-by: Md Haris Iqbal <haris.iqbal@xxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 8 --------
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 ++++++++
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> index 2f981ae97076..cf6a2be61695 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
> @@ -152,13 +152,6 @@ static struct attribute_group rtrs_srv_stats_attr_group = {
> .attrs = rtrs_srv_stats_attrs,
> };
>
> -static void rtrs_srv_dev_release(struct device *dev)
> -{
> - struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);
> -
> - kfree(srv);
> -}
> -
> static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
> {
> struct rtrs_srv *srv = sess->srv;
> @@ -172,7 +165,6 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
> goto unlock;
> }
> srv->dev.class = rtrs_dev_class;
> - srv->dev.release = rtrs_srv_dev_release;
> err = dev_set_name(&srv->dev, "%s", sess->s.sessname);
> if (err)
> goto unlock;
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> index b61a18e57aeb..28f6414dfa3d 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> @@ -1319,6 +1319,13 @@ static int rtrs_srv_get_next_cq_vector(struct rtrs_srv_sess *sess)
> return sess->cur_cq_vector;
> }
>
> +static void rtrs_srv_dev_release(struct device *dev)
> +{
> + struct rtrs_srv *srv = container_of(dev, struct rtrs_srv, dev);
> +
> + kfree(srv);
> +}
> +
> static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,
> const uuid_t *paths_uuid)
> {
> @@ -1337,6 +1344,7 @@ static struct rtrs_srv *__alloc_srv(struct rtrs_srv_ctx *ctx,
> srv->queue_depth = sess_queue_depth;
> srv->ctx = ctx;
> device_initialize(&srv->dev);
> + srv->dev.release = rtrs_srv_dev_release;
>
> srv->chunks = kcalloc(srv->queue_depth, sizeof(*srv->chunks),
> GFP_KERNEL);
> --
> 2.25.1
>
