On Sun, Aug 30, 2020 at 11:40:06AM +0300, Leon Romanovsky wrote:
> /**
> - * ib_free_cq_user - free a completion queue
> + * ib_free_cq - free a completion queue
> * @cq: completion queue to free.
> - * @udata: User data or NULL for kernel object
> */
> -void ib_free_cq_user(struct ib_cq *cq, struct ib_udata *udata)
> +void ib_free_cq(struct ib_cq *cq)
> {
> - if (WARN_ON_ONCE(atomic_read(&cq->usecnt)))
> - return;
> - if (WARN_ON_ONCE(cq->cqe_used))
> - return;
> + WARN_ON_ONCE(atomic_read(&cq->usecnt));
In this case we expect ops.destroy_cq to fail, so no sense in
continuing, leak everything, the ULP is buggy.
Jason
