Re: [PATCH for-next] RDMA/core: Add a debug print when a driver is marked as non-kverbs provider

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/08/2020 19:28, Jason Gunthorpe wrote:
> On Tue, Aug 18, 2020 at 11:38:31AM +0300, Gal Pressman wrote:
>> Add a debug print which is emitted when a certain driver is marked as
>> non-kverbs provider. This allows for easier understanding of why kverbs
>> functionality isn't working in such cases.
>>
>> In addition, print the name of the first mandatory verb that is missing.
>> This brings back use for the unused name field.
>>
>> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
>> ---
>>  drivers/infiniband/core/device.c | 4 ++++
>>  1 file changed, 4 insertions(+)
> 
> Kinda wondering why here? The debug level doesn't print by default
> does it?

Nope, I assume that a user that wants to debug why things aren't working is
going to enable debug prints. What do you mean by where here? Do you have a more
appropriate place in mind?

I thought this could be helpful, I can remove the print and the name field if
you prefer.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux