Hi, On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote: > On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > > were later converted to fallthrough statements by commit df561f6688fe > > ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity > > warning about unreachable code. > > > > It's worth mentioning that this warning is triggered only by compilers > that don't support __attribute__((__fallthrough__)), which has been > supported since GCC 7.1. > > > Remove the fallthrough statements. > > > > Addresses-Coverity: ("Unreachable code") > > Fixes: 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > Signed-off-by: Alex Dewar <alex.dewar90@xxxxxxxxx> > > Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > I can take this in my tree for 5.9-rc3. Thanks -- Gustavo