On 25/08/2020 19:35, Jason Gunthorpe wrote:
> Drivers that fail destroy can cause uverbs to leak uobjects. Drivers are
> required to always eventually destroy their ubojects, so trigger a WARN_ON
> to detect this driver bug.
>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> ---
> drivers/infiniband/core/rdma_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/rdma_core.c b/drivers/infiniband/core/rdma_core.c
> index 3962da54ffbf47..d2b5417a4d5170 100644
> --- a/drivers/infiniband/core/rdma_core.c
> +++ b/drivers/infiniband/core/rdma_core.c
> @@ -895,8 +895,9 @@ void uverbs_destroy_ufile_hw(struct ib_uverbs_file *ufile,
> if (__uverbs_cleanup_ufile(ufile, reason)) {
> /*
> * No entry was cleaned-up successfully during this
> - * iteration
> + * iteration. It is a driver bug to fail destruction.
> */
> + WARN_ON(!list_empty(&ufile->uobjects));
> break;
> }
>
>
Looks good,
Reviewed-by: Gal Pressman <galpress@xxxxxxxxxx>
