On 2020/8/25 1:17, Jason Gunthorpe wrote: > On Mon, Aug 17, 2020 at 07:58:52PM +0800, Weihang Li wrote: >> From: Lang Cheng <chenglang@xxxxxxxxxx> >> >> It should be considered as an illegal operation if the ULP attempts to >> modify a QP from another state to the current hardware state. Otherwise, >> the ULP can modify some fields of QPC at any time. For example, for a QP in >> state of RTS, modify it from RTR to RTS can change the PSN, which is always >> not as expected. >> >> Signed-off-by: Lang Cheng <chenglang@xxxxxxxxxx> >> Signed-off-by: Weihang Li <liweihang@xxxxxxxxxx> >> --- >> drivers/infiniband/hw/hns/hns_roce_qp.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) > > This looks like it needs a fixes line? > > Jason > Thanks for your reminder, will add a fixes tag and send a new version. Weihang
