> On 21 Aug 2020, at 10:10, Dinghao Liu <dinghao.liu@xxxxxxxxxx> wrote: > > When ida_alloc_max() fails, uverbs_dev should be freed > just like when init_srcu_struct() fails. It's the same > for the error paths after this call. > > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx> > --- > drivers/infiniband/core/uverbs_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c > index 37794d88b1f3..c6b4e3e2aff6 100644 > --- a/drivers/infiniband/core/uverbs_main.c > +++ b/drivers/infiniband/core/uverbs_main.c > @@ -1170,6 +1170,7 @@ static int ib_uverbs_add_one(struct ib_device *device) > ib_uverbs_comp_dev(uverbs_dev); > wait_for_completion(&uverbs_dev->comp); > put_device(&uverbs_dev->dev); > + kfree(uverbs_dev); Isn't this taken care of by the *release* function pointer, which happens to be ib_uverbs_release_dev() ? Thxs, Håkon > return ret; > } > > -- > 2.17.1 >
