On 19. 08. 20, 14:43, Jiri Slaby wrote:
> On 09. 07. 20, 14:33, Daniel Vetter wrote:
>> Exactly matches the one in the helpers.
>
> It's not that exact. The order of modeset_enables and planes is
> different. And this causes a regression -- no fb in qemu.
>
> So if I run drm-tip, no fb.
> If I revert 73f15a9, it works.
> If I then switch the two calls in vgdev_atomic_commit_tail, it doesn't
> work again.
>
> So the order apparently matters.
And it was the intention, it seems:
commit e7cf0963f816fa44190caaf51aeffaa614c340c6
Author: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Tue May 31 08:50:47 2016 +0200
virtio-gpu: add atomic_commit function
Do modesets first, then call drm_atomic_helper_commit_planes with
active_only = true. That way the outputs doesn't get disabled
temporarly on atomic commits.
thanks,
--
js
