Re: [PATCH for-rc] RDMA/usnic: Fix reported max_pkeys attribute

[Kamal Heib <kamalheib1@xxxxxxxxx>]

On Wed, Aug 05, 2020 at 07:17:42PM -0300, Jason Gunthorpe wrote:
> On Thu, Aug 06, 2020 at 12:00:51AM +0300, Kamal Heib wrote:
> > Make sure to report the right max_pkeys attribute value to indicate the
> > maximum number of partitions supported by the usnic device.
> 
> Why does usnic support pkeys? This needs more explanation
> 
> Jason

Looks like the usnic provider is acting like the RoCE providers by returning
the default pkey when calling the query_pkey() callback, Do you think that
this needs to removed like what was done for iWarp providers?

int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index,
                                u16 *pkey)
{
        if (index > 0)
                return -EINVAL;

        *pkey = 0xffff;
        return 0;
}

Thanks,
Kamal