On Wed, Jul 15, 2020 at 08:57:40AM +0000, Mikhail Malygin wrote: > > > Why is this READ_ONCE? The wr list at this point cannot be allowed to > > change > > > > Jason > > The idea behind this READ_ONCE was to make sure read of wr->next > happens before post_send_one(), as there is no data dependency > between post_send_one and read of wr->next. However I’m not 100% > sure this is necessary here. The spinock in post_one_send() guarantees no reordering across post_one_send() Jason