Re: [PATCH iproute2-next v1 1/4] rdma: update uapi headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/24/20 4:40 AM, Leon Romanovsky wrote:
> diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h
> index ae5a77a1..fe127b88 100644
> --- a/rdma/include/uapi/rdma/rdma_netlink.h
> +++ b/rdma/include/uapi/rdma/rdma_netlink.h
> @@ -287,6 +287,12 @@ enum rdma_nldev_command {
>  
>  	RDMA_NLDEV_CMD_STAT_DEL,
>  
> +	RDMA_NLDEV_CMD_RES_QP_GET_RAW, /* can dump */
> +
> +	RDMA_NLDEV_CMD_RES_CQ_GET_RAW, /* can dump */
> +
> +	RDMA_NLDEV_CMD_RES_MR_GET_RAW, /* can dump */
> +
>  	RDMA_NLDEV_NUM_OPS
>  };

you are inserting new commands in the middle which breaks existing users
of this API.




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux