Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/29/20 4:41 PM, David Miller wrote:
From: rao.shoaib@xxxxxxxxxx
Date: Wed, 27 May 2020 01:17:42 -0700

diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index cba368e55863..7273c681e6c1 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -64,7 +64,7 @@
/* supported values for SO_RDS_TRANSPORT */
  #define	RDS_TRANS_IB	0
-#define	RDS_TRANS_IWARP	1
+#define	RDS_TRANS_GAP	1
  #define	RDS_TRANS_TCP	2
  #define RDS_TRANS_COUNT	3
  #define	RDS_TRANS_NONE	(~0)
You can't break user facing UAPI like this, sorry.

I was hoping that this could be considered an exception as IWARP has been deprecated for almost a decade and there is no current product using it. With the change any old binary will continue to work, a new compilation fill fail so that the code can be examined, otherwise we will never be able to reuse this number.

If the above is not acceptable I can revert this part of the change.

Shoaib




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux