On Wed, May 27, 2020 at 1:01 AM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > > On Tue, May 26, 2020 at 01:20:00AM -0400, Devesh Sharma wrote: > > This series is mainly focused on adding driver fast path > > changes to support variable sized wqe support. There are > > two patches. > > > > The first patch is a big patch and contain core changes to > > support the feature. Since the change is related to fast > > path, the patch is not splitted into multiple patches. > > We want to push all related changes in one go. > > That makes no sense, everyone else splits their patches. I agree with both you and Leon about the size of the patch and there is a guideline of sending smaller patches. I will have to see which all parts I can split and re-send. I was not sure about the functionality of the driver wrt each patch which comes out as a result of split. These changes are quite closely woven. I will try though and send a V2. Thanks > > > The second patch is relatively few lines and changes the > > ABI. > > > > The corresponding library changes will follow short after > > this patch series. > > You have to open a PR on rdma-core before any uapi changes should be > merged. Yeah sure, I will open that. > > Jason