Re: [PATCH rdma-next v1 2/9] RDMA/mlx5: Get ECE options from FW during create QP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 25, 2020 at 03:17:37PM -0300, Jason Gunthorpe wrote:
> On Sat, May 23, 2020 at 04:22:36PM +0300, Leon Romanovsky wrote:
> > -int mlx5_core_create_qp(struct mlx5_ib_dev *dev, struct mlx5_core_qp *qp,
> > -			u32 *in, int inlen)
> > +int mlx5_qpc_create_qp(struct mlx5_ib_dev *dev, struct mlx5_core_qp *qp,
> > +		       u32 *in, int inlen, u32 *out)
> >  {
> > -	u32 out[MLX5_ST_SZ_DW(create_qp_out)] = {};
> >  	u32 din[MLX5_ST_SZ_DW(destroy_qp_in)] = {};
> >  	int err;
> >
> >  	MLX5_SET(create_qp_in, in, opcode, MLX5_CMD_OP_CREATE_QP);
> >
> > -	err = mlx5_cmd_exec(dev->mdev, in, inlen, out, sizeof(out));
> > +	err = mlx5_cmd_exec(dev->mdev, in, inlen, out,
> > +			    MLX5_ST_SZ_BYTES(create_qp_out));
> >  	if (err)
> >  		return err;
>
> This hunk is unrelated right? Was missed in that other series?

Not really, in this hunk, I changed mlx5_qpc_create_qp() signature too,
it now receives "u32 *out", which is known size.

Thanks

>
> Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux