On Fri, May 22, 2020 at 02:33:38PM -0700, Bart Van Assche wrote:
> Increase the flexibility of the SRP initiator driver by making the channel
> count configurable per target instead of only providing a kernel module
> parameter for configuring the channel count.
>
> Cc: Laurence Oberman <loberman@xxxxxxxxxx>
> Cc: Kamal Heib <kamalheib1@xxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/infiniband/ulp/srp/ib_srp.c | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 00b4f88b113e..d686c39710c0 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -3424,6 +3424,7 @@ enum {
> SRP_OPT_IP_DEST = 1 << 16,
> SRP_OPT_TARGET_CAN_QUEUE= 1 << 17,
> SRP_OPT_MAX_IT_IU_SIZE = 1 << 18,
> + SRP_OPT_CH_COUNT = 1 << 19,
> };
>
> static unsigned int srp_opt_mandatory[] = {
> @@ -3457,6 +3458,7 @@ static const match_table_t srp_opt_tokens = {
> { SRP_OPT_IP_SRC, "src=%s" },
> { SRP_OPT_IP_DEST, "dest=%s" },
> { SRP_OPT_MAX_IT_IU_SIZE, "max_it_iu_size=%d" },
> + { SRP_OPT_CH_COUNT, "ch_count=%d", },
Why did you use %d and not %u?
Thanks
