On Fri, May 22, 2020 at 10:28 AM <haris.phnx@xxxxxxxxx> wrote:
>
> From: Md Haris Iqbal <haris.phnx@xxxxxxxxx>
>
> The rtrs_sess structure has already been extracted above from the
> rtrs_srv_sess structure. Use that to avoid redundant dereferencing.
>
> Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality")
> Signed-off-by: Md Haris Iqbal <haris.phnx@xxxxxxxxx>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> index 1fc6ece036ff..5ef8988ee75b 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> @@ -1822,13 +1822,13 @@ static int rtrs_rdma_connect(struct rdma_cm_id *cm_id,
> /*
> * Sanity checks
> */
> - if (con_num != sess->s.con_num || cid >= sess->s.con_num) {
> + if (con_num != s->con_num || cid >= s->con_num) {
> rtrs_err(s, "Incorrect request: %d, %d\n",
> cid, con_num);
> mutex_unlock(&srv->paths_mutex);
> goto reject_w_econnreset;
> }
> - if (sess->s.con[cid]) {
> + if (s->con[cid]) {
> rtrs_err(s, "Connection already exists: %d\n",
> cid);
> mutex_unlock(&srv->paths_mutex);
> --
> 2.25.1
>
Acked-by: Danil Kipnis <danil.kipnis@xxxxxxxxxxxxxxx>
Thanks Haris.
