Hi Greg, Jason, On 5/20/2020 12:32 PM, Jeff Kirsher wrote: > From: Dave Ertman <david.m.ertman@xxxxxxxxx> > > +static const > +struct virtbus_dev_id *virtbus_match_id(const struct virtbus_dev_id *id, > + struct virtbus_device *vdev) > +{ > + while (id->name[0]) { > + if (!strcmp(vdev->match_name, id->name)) > + return id; Should we have VID, DID based approach instead of _any_ string chosen by vendor drivers? This will required central place to define the VID, DID of the vdev in vdev_ids.h to have unique ids.