Re: [RDMA RFC v6 14/16] RDMA/irdma: Add ABI definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/05/2020 11:52, Greg KH wrote:
> On Wed, May 20, 2020 at 10:54:25AM +0300, Gal Pressman wrote:
>> On 20/05/2020 10:04, Jeff Kirsher wrote:
>>> +struct i40iw_create_qp_resp {
>>> +   __u32 qp_id;
>>> +   __u32 actual_sq_size;
>>> +   __u32 actual_rq_size;
>>> +   __u32 i40iw_drv_opt;
>>> +   __u16 push_idx;
>>> +   __u8 lsmm;
>>> +   __u8 rsvd;
>>> +};
>>
>> This struct size should be 8 bytes aligned.
> 
> Aligned in what way?  Seems sane to me, what would you want it to look
> like instead?

The uverbs ABI structs sizes are assumed to be padded to 8 bytes alignment, I
would expect the reserved field to be an array of 5 bytes as done in other
structs in this file (irdma_modify_qp_req for example).
Jason could correct me if I'm wrong?



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux