On Tue, May 19, 2020 at 04:32:23PM +0300, Dan Carpenter wrote: > The problem is that "req->sg_cnt" is an unsigned int so if "nr" is > negative, it gets type promoted to a high positive value and the > condition is false. This patch fixes it by handling negatives separately. > > Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx> > --- > v2: propagate the correct error code instead of returning -EINVAL > > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 7 +++---- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2 +- > 2 files changed, 4 insertions(+), 5 deletions(-) Applied to for-next, thanks Jason