[rdma:wip/jgg-for-next 106/128] drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jack,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head:   41d5e318ccb34bded248a7a4c97264fdb1c8a42e
commit: c013fbc1fd341d28269cf0a6b465925186b9a1e1 [106/128] RDMA/rtrs: include client and server modules into kernel compilation
config: i386-allyesconfig (attached as .config)

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

smatch warnings:
drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting
drivers/infiniband/ulp/rtrs/rtrs-clt.c:2890 rtrs_clt_request() warn: inconsistent indenting

vim +1196 drivers/infiniband/ulp/rtrs/rtrs-clt.c

6a98d71daea186 Jack Wang 2020-05-11  1166  
6a98d71daea186 Jack Wang 2020-05-11  1167  /**
6a98d71daea186 Jack Wang 2020-05-11  1168   * rtrs_clt_failover_req() Try to find an active path for a failed request
6a98d71daea186 Jack Wang 2020-05-11  1169   * @clt: clt context
6a98d71daea186 Jack Wang 2020-05-11  1170   * @fail_req: a failed io request.
6a98d71daea186 Jack Wang 2020-05-11  1171   */
6a98d71daea186 Jack Wang 2020-05-11  1172  static int rtrs_clt_failover_req(struct rtrs_clt *clt,
6a98d71daea186 Jack Wang 2020-05-11  1173  				 struct rtrs_clt_io_req *fail_req)
6a98d71daea186 Jack Wang 2020-05-11  1174  {
6a98d71daea186 Jack Wang 2020-05-11  1175  	struct rtrs_clt_sess *alive_sess;
6a98d71daea186 Jack Wang 2020-05-11  1176  	struct rtrs_clt_io_req *req;
6a98d71daea186 Jack Wang 2020-05-11  1177  	int err = -ECONNABORTED;
6a98d71daea186 Jack Wang 2020-05-11  1178  	struct path_it it;
6a98d71daea186 Jack Wang 2020-05-11  1179  
6a98d71daea186 Jack Wang 2020-05-11  1180  	do_each_path(alive_sess, clt, &it) {
6a98d71daea186 Jack Wang 2020-05-11  1181  		if (unlikely(READ_ONCE(alive_sess->state) !=
6a98d71daea186 Jack Wang 2020-05-11  1182  			     RTRS_CLT_CONNECTED))
6a98d71daea186 Jack Wang 2020-05-11  1183  			continue;
6a98d71daea186 Jack Wang 2020-05-11  1184  		req = rtrs_clt_get_copy_req(alive_sess, fail_req);
6a98d71daea186 Jack Wang 2020-05-11  1185  		if (req->dir == DMA_TO_DEVICE)
6a98d71daea186 Jack Wang 2020-05-11  1186  			err = rtrs_clt_write_req(req);
6a98d71daea186 Jack Wang 2020-05-11  1187  		else
6a98d71daea186 Jack Wang 2020-05-11  1188  			err = rtrs_clt_read_req(req);
6a98d71daea186 Jack Wang 2020-05-11  1189  		if (unlikely(err)) {
6a98d71daea186 Jack Wang 2020-05-11  1190  			req->in_use = false;
6a98d71daea186 Jack Wang 2020-05-11  1191  			continue;
6a98d71daea186 Jack Wang 2020-05-11  1192  		}
6a98d71daea186 Jack Wang 2020-05-11  1193  		/* Success path */
6a98d71daea186 Jack Wang 2020-05-11  1194  		rtrs_clt_inc_failover_cnt(alive_sess->stats);
6a98d71daea186 Jack Wang 2020-05-11  1195  		break;
6a98d71daea186 Jack Wang 2020-05-11 @1196  	} while_each_path(&it);
6a98d71daea186 Jack Wang 2020-05-11  1197  
6a98d71daea186 Jack Wang 2020-05-11  1198  	return err;
6a98d71daea186 Jack Wang 2020-05-11  1199  }
6a98d71daea186 Jack Wang 2020-05-11  1200  

:::::: The code at line 1196 was first introduced by commit
:::::: 6a98d71daea186247005099758af549e6afdd244 RDMA/rtrs: client: main functionality

:::::: TO: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>
:::::: CC: Jason Gunthorpe <jgg@xxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux