Re: [PATCH rdma-next v1 02/10] IB/uverbs: Refactor related objects to use their own asynchronous event FD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 06, 2020 at 11:24:36AM +0300, Leon Romanovsky wrote:
> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> index 7959f618b8a5..1d147beaf4cc 100644
> +++ b/drivers/infiniband/core/uverbs_cmd.c
> @@ -1051,6 +1051,10 @@ static struct ib_ucq_object *create_cq(struct uverbs_attr_bundle *attrs,
>  		goto err_free;
>  
>  	obj->uevent.uobject.object = cq;
> +	obj->uevent.event_file = attrs->ufile->default_async_file;

default_async_file always has to be read with READ_ONCE since there is
no locking.

This repeating pattern should probably be in ia helper function like
was introduced in patch 3 for the ioctl side.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux