On 5/14/2020 7:00 PM, Gal Pressman wrote:
On 14/05/2020 15:02, Max Gurtovoy wrote:
This series removes the support for FMR mode to register memory. This ancient
mode is unsafe and not maintained/tested in the last few years. It also doesn't
have any reasonable advantage over other memory registration methods such as
FRWR (that is implemented in all the recent RDMA adapters). This series should
be reviewed and approved by the maintainer of the effected drivers and I
suggest to test it as well.
The tests that I made for this series (fio benchmarks and fio verify data):
1. iSER initiator on ConnectX-4
2. iSER initiator on ConnectX-3
3. SRP initiator on ConnectX-4 (loopback to SRP target)
4. SRP initiator on ConnectX-3
Not tested:
1. RDS
2. mthca
3. rdmavt
I think there are a few leftovers:
From f289a67b47e03d268469211065bf114cbb1c7125 Mon Sep 17 00:00:00 2001
From: Gal Pressman <galpress@xxxxxxxxxx>
Date: Wed, 13 May 2020 10:49:09 +0300
Subject: [PATCH] RDMA/mlx5: Remove FMR leftovers
Remove a few leftovers from FMR functionality which are no longer used.
Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
index 482b54eb9764..40c461017763 100644
--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h
+++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h
@@ -675,12 +675,6 @@ struct umr_common {
struct semaphore sem;
};
-enum {
- MLX5_FMR_INVALID,
- MLX5_FMR_VALID,
- MLX5_FMR_BUSY,
-};
-
struct mlx5_cache_ent {
struct list_head head;
/* sync access to the cahce entry
@@ -1253,8 +1247,6 @@ int mlx5_query_mad_ifc_port(struct ib_device *ibdev, u8 port,
struct ib_port_attr *props);
int mlx5_ib_query_port(struct ib_device *ibdev, u8 port,
struct ib_port_attr *props);
-int mlx5_ib_init_fmr(struct mlx5_ib_dev *dev);
-void mlx5_ib_cleanup_fmr(struct mlx5_ib_dev *dev);
void mlx5_ib_cont_pages(struct ib_umem *umem, u64 addr,
unsigned long max_page_shift,
int *count, int *shift,
Thanks Gal.
This is a dead code regardless to this series but I'll add it.
