On 2020-05-13 09:03, Max Gurtovoy wrote: > > On 5/13/2020 6:11 PM, Bart Van Assche wrote: >> On 2020-05-13 07:49, Max Gurtovoy wrote: >>> FMR is not supported on most recent RDMA devices (that use fast memory >>> registration mechanism). Also, FMR was recently removed from NFS/RDMA >>> ULP. >> Please mention how this patch has been tested. > > It was tested using loopback SRP connection on ConnectX-4 HCA and > ib_srpt target (rdma_cm connection establishment). > > >> >>> @@ -71,7 +71,7 @@ >>> static unsigned int cmd_sg_entries; >>> static unsigned int indirect_sg_entries; >>> static bool allow_ext_sg; >>> -static bool prefer_fr = true; >>> +static bool prefer_fr; >>> static bool register_always = true; >>> static bool never_register; >>> static int topspin_workarounds = 1; >> Is this change necessary? > > No. But why this should be set ? To reflect the behavior of the SRP driver, namely that is using FRWR instead of FMR. Thanks, Bart.
