On Wed, May 13, 2020 at 05:49:30PM +0300, Max Gurtovoy wrote: > FMR is not supported on most recent RDMA devices (that use fast memory > registration mechanism). Also, FMR was recently removed from NFS/RDMA > ULP. > > Signed-off-by: Max Gurtovoy <maxg@xxxxxxxxxxxx> > Reviewed-by: Israel Rukshin <israelr@xxxxxxxxxxxx> > drivers/infiniband/ulp/srp/ib_srp.c | 221 +++--------------------------------- > drivers/infiniband/ulp/srp/ib_srp.h | 27 +---- > 2 files changed, 24 insertions(+), 224 deletions(-) > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c > index cd1181c..73ffb00 100644 > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -71,7 +71,7 @@ > static unsigned int cmd_sg_entries; > static unsigned int indirect_sg_entries; > static bool allow_ext_sg; > -static bool prefer_fr = true; > +static bool prefer_fr; > static bool register_always = true; > static bool never_register; > static int topspin_workarounds = 1; > @@ -97,7 +97,7 @@ > > module_param(prefer_fr, bool, 0444); > MODULE_PARM_DESC(prefer_fr, > -"Whether to use fast registration if both FMR and fast registration are supported"); > +"Whether to use fast registration if both FMR and fast registration are supported [deprecated]"); Why are we not just deleting this? iser and srp are the only remaining users of FMR? Please send this as a series including additional patches to remove all things related to fmr, eg the drivers/infiniband/core/fmr_pool.c, headers, ops, verbs, driver support, etc. Jason
